[libc][bazel] explicitly use system-provided errno in Bazel builds. #130663
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressing the comments from PR llvm#130368 review. Since Bazel builds are effectively overlay mode, switch to explicitly setting -DLIBC_ERRNO_MODE=LIBC_ERRNO_MODE_SYSTEM configuration option, so that unit tests and release builds are consistent. Verified that all the unit tests pass with this flag specified.
vonosmas
added
bazel
Member
|
@llvm/pr-subscribers-libc Author: Alexey Samsonov (vonosmas) ChangesAddressing the comments from PR #130368 review. Since Bazel builds are effectively overlay mode, switch to explicitly setting -DLIBC_ERRNO_MODE=LIBC_ERRNO_MODE_SYSTEM configuration option, so that unit tests and release builds are consistent. Verified that all the unit tests pass with this flag specified. Full diff: https://github.com/llvm/llvm-project/pull/130663.diff 1 Files Affected:
diff --git a/utils/bazel/llvm-project-overlay/libc/libc_configure_options.bzl b/utils/bazel/llvm-project-overlay/libc/libc_configure_options.bzl
index f65da9e98226b..672ce8c0723ec 100644
--- a/utils/bazel/llvm-project-overlay/libc/libc_configure_options.bzl
+++ b/utils/bazel/llvm-project-overlay/libc/libc_configure_options.bzl
@@ -44,6 +44,11 @@ LIBC_CONFIGURE_OPTIONS = [
# "LIBC_COPT_STRTOFLOAT_DISABLE_EISEL_LEMIRE",
# "LIBC_COPT_STRTOFLOAT_DISABLE_SIMPLE_DECIMAL_CONVERSION",
+ # Documentation in libc/src/errno/...
+ # Since we're only using Bazel for overlay build for now, explicitly
+ # enforce using the system-provided errno in both tests and release build.
+ "LIBC_ERRNO_MODE=LIBC_ERRNO_MODE_SYSTEM",
+
# Documentation in libc/src/__support/libc_assert.h
# "LIBC_COPT_USE_C_ASSERT",
]
|
lntue
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing the comments from PR #130368 review. Since Bazel builds are effectively overlay mode, switch to explicitly setting -DLIBC_ERRNO_MODE=LIBC_ERRNO_MODE_SYSTEM configuration option, so that unit tests and release builds are consistent. Verified that all the unit tests pass with this flag specified.